[#UP-907] Static Log instances should be declared as LOG

uPortal

Static Log instances should be declared as LOG

Created: 31/Mar/05 10:38 AM Updated: 05/Aug/08 02:44 PM

Component/s:

None

Affects Version/s:

2.4, 2.4.1, 2.4.2, 2.5.0 M1, 2.6.0 M1, 2.5.1 RC1, 2.5.0 RC1, 2.5.0 RC3, 2.5.0 RC2, 2.5.0 GA, 2.5.1 RC2, 2.5.2 RC1, 2.5.1 RC3, 2.5.1 GA, 2.5.3 RC1, 2.5.2 GA, 2.5.3 RC2, 2.5.3 RC3, 2.5.3 GA, 2.6.0 RC1, 2.6.0 RC2, 2.6.0 GA, 2.6.1 RC1, 2.6.1 RC2

Fix Version/s:

3.1.0

Original Estimate:

Unknown

Remaining Estimate:

Unknown

Time Spent:

Unknown

Issue Links:

Generic Relation

This issue relates to:
	UP-910 Use protected instance for Log rather...

Description

« Hide

Where we declare static Log instances, they should be all caps:

private static final Log log = LogFactory.getLog(UserLayoutStoreFactory.class);
should be:
private static final Log LOG = LogFactory.getLog(UserLayoutStoreFactory.class);

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Andrew Petro [31/Mar/05 01:22 PM]

This task also includes updating http://jasigch.princeton.edu:9000/display/UPC/LoggingBestPractices to reflect this new practice.

[ Permlink | « Hide ]

Andrew Petro [16/Apr/05 08:24 PM]

Pushing back this issue as it will touch many lines of code. Too late for Tuesday's milestone. We need to resolve whether we're doing this at all for uP 2.5.0. If we are, let's do it soon after M1.

[ Permlink | « Hide ]

Andrew Petro [04/May/05 10:19 AM]

Posted to the dev list about this issue but didn't get much of a response:

https://list.unm.edu/cgi-bin/wa?A2=ind0503&L=JASIG-DEV&P=R57498&I=-3

Just changing what we call our static log instance isn't such a big deal, but switching to use an instance rather than static Log instance is vital for classes we subclass, so that logging happening in the super-class-implemented portion of the extending classes is logged to the same logger as the code implemented in the subclass itself.