No one calls destroyThread() or stopWorker(). If someone were to call these methods, we'd either get deadlock or infinite recursion.

In looking through the Worker class in search of performance issues, Faizan and I noticed Worker.that stopWorker currently calls ThreadPool.destroyThread(this).

Currently the portal is using BoundedThreadPool and its destroyThread(Worker worker) implementation calls worker.stopWorker() which in turn calls destroyThread(this).

On top of that destroyThread is synchronized. There appears to be an opporunity here for either deadlock or StackOverflows (or whatever is thrown with those types of infinite loops) or both! Currently, stopWorker and destroyThread appear to call each other so this code is never actually executed. However, if executed accidentally it could have some adverse affects.