History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: UP-1983
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Eric Dalquist
Reporter: Tuyhang Ly
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
uPortal

Missing link to move a channel to a different location in User Preferences channel

Created: 28/Mar/08 01:41 PM   Updated: 18/Apr/08 10:52 AM
Component/s: User Interface, Distributed Layout Management (DLM)
Affects Version/s: 3.0.0-RC2, 3.0.0-RC3
Fix Version/s: 3.0.0

Original Estimate: Unknown Remaining Estimate: Unknown Time Spent: Unknown


 Description  « Hide
I'm unable to move a channel to another tab using the "User Preferences" channel. The "Move this channel to a different location" link is missing from the "Options for modifying this channel:" list as it used to be there in version 2.5.*.

 All   Comments   Work Log   Change History      Sort Order:
Jen Bourey [06/Apr/08 04:13 PM]
I can't find any evidence of this feature existing in up2.6. It seems that either it was lost prior to the 2.6 release, or perhaps was a local modification.

Paul Gazda [07/Apr/08 10:35 AM]
The feature definitely existed in up 2.5.2 which is what we have installed. When selecting a channel in Preferences the menu shows:
Options for modifying this channel:
  • Move this channel to a different location
  • Delete this channel
  • Cancel and return

Eric Dalquist [07/Apr/08 10:46 AM]
Paul, Are you using SLM, ALM or DLM?

Paul Gazda [07/Apr/08 10:56 AM]
We are using DLM.

Jen Bourey [09/Apr/08 06:00 PM]
I've just looked through the source revision history, and it appears that the DLMUserPreferences channel has never supported this feature. Is it possible that you're using CUserPreferences as your user preferences channel?

Paul Gazda [09/Apr/08 07:17 PM]
I talked to my colleague who actually converted us from SLM to DLM and found that she had re-instated the "Move this channel to a different location" link to the DLM preferences channel when she found it was missing from DLM. So it is a custom mod. Sorry for my reviously misleading info. We are on uPortal version 2.5.2, so we do not have drag and drop channel movement. The "Move this channel..." item is the only way to move a channel from one tab to another. I don't know if drag and drop lets you move a channel to another tab.

Eric Dalquist [09/Apr/08 07:37 PM]
Paul, could you share this modification with us via a patch? It sounds
like it wasn't too terribly difficult and would be a good addition.

Holly Coast [10/Apr/08 06:13 PM]
Hi all, I'm the one that made that local mod to our stylesheet. I'm sorry, I don't know how to create a patch file, but the changes are minor so hopefully just describing them here will suffice. I'll put plenty of context lines around my changes so you should be able to find the same place in the file.

The file is webpages/stylesheets/org/jasig/portal/channels/DLMUserPreferences/tab-column/default.xsl


Change #1: Around about line 247 was this section:

<td class="{$tabClass}" nowrap="nowrap">
<A ID="tab" onMouseover="window.status=''; return true;" class="{$anchorClass}">
<xsl:choose>
<xsl:when test="$action = 'moveColumn' or $action = 'moveChannel'">
<xsl:attribute name="href">
<xsl:value-of select="$baseActionURL"/>?action=<xsl:value-of select="$action"/>&activeTab=<xsl:value-of select="$activeTabID"/>
</xsl:attribute>
</xsl:when>
<xsl:otherwise>
<xsl:attribute name="href">
<xsl:value-of select="$baseActionURL"/>?action=selectTab&activeTab=<xsl:value-of select="@ID"/>
</xsl:attribute>
</xsl:otherwise>
</xsl:choose>
<SPAN CLASS="{$fontClass}">
<xsl:value-of select="@name"/>
</SPAN>
</A>
</td>

I changed that sixth line (in bold above) to the following (change is at the very end of the line):

<xsl:value-of select="$baseActionURL"/>?action=<xsl:value-of select="$action"/>&activeTab=<xsl:value-of select="@ID"/>


Change #2: About line 1440 was this section:

End of channel rename section-->
<!-- If ancestor is immutable - the channel cannot be moved-->
<!--
<xsl:if test="not(/layout/descendant::*[@ID=$elementID]/ancestor::folder[@immutable='true'])">
<tr><td colspan="2" width="100%" class="uportal-channel-text"><a href="{$baseActionURL}?action=moveChannel&elementID={$elementID}" onMouseover="window.status=''; return true;"><img alt="Move this channel" title="Move this channel" src="{$mediaPath}/bullet.gif" hspace="7" width="9" height="9" border="0"/>Move this channel to a different location</a></td></tr>
</xsl:if>
-->

Notice that the above section is commented out; I removed the commenting marks and changed the xsl:if line (in italics above - I couldn't use the wiki markup to bold it because the line contains an asterisk) to the following:

<xsl:if test="not(/layout/descendant::*[@ID=$elementID]/ancestor::folder[@immutable='true'])
and (not(/layout/folder/descendant::*[@ID = $elementID]/@dlm:moveAllowed)
or (/layout/folder/descendant::*[@ID = $elementID]/@dlm:moveAllowed != 'false'))">


I think that's all I did at the time. I've since made other changes to that file for other reasons, so if this doesn't work for you please let me know and I'll see if there's something I missed.


Holly Coast [10/Apr/08 06:41 PM]
I should have mentioned that the above changes were made to the 2.5.1 stylesheet back in August of 2006. So I don't know how well my line number references will match up to the latest version.

Eric Dalquist [10/Apr/08 09:16 PM]
Thank you Paul and Holly for the fix it works great.