History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: UP-1766
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Trivial Trivial
Assignee: Andrew Wills
Reporter: Eric Dalquist
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
uPortal

New deployPortletApp can result in non-validating web.xml

Created: 05/Jul/07 01:53 PM   Updated: 05/Mar/08 07:59 AM
Component/s: None
Affects Version/s: 2.6.0 GA, 2.6.1 RC1, 2.6.1 RC2
Fix Version/s: 2.6.1

Original Estimate: Unknown Remaining Estimate: Unknown Time Spent: Unknown
File Attachments: 1. XML File bad-web.xml (4 kb)
2. XML File original-web.xml (3 kb)



 Description  « Hide
The work on UP-1241 can result in a web.xml that does not validate against the servlet 2.4 schema. This is the case if there are already entries in the web.xml as the pluto information is added at the top of the file no matter what.

 All   Comments   Work Log   Change History      Sort Order:
Eric Dalquist [05/Jul/07 01:54 PM]
web.xml prior to running deployPortletApp

Eric Dalquist [05/Jul/07 01:55 PM]
web.xml after running deployPortletApp, note that the added servlet and servlet-mapping entries are in the incorrect locations in the file.

Andrew Wills [26/Jul/07 12:43 PM]
I've cleared up the trouble with element order, but there is still an issue with namespacing that exhibits the same symptoms.

The previous deployer always applied the same version (was it 2.3?). That version didn't use namespacing. The new version – the one required for the latest-and-greatest JSTL – does use namespacing.

Add to that the fact that many of the web.xml documents I've seen from real portlet applications (esp. UNICON training) don't declare a version at all... they may only contain <web-app>.

The goal of the new deployer, in this area, was not to change what the original portlet app provides, which might be:

  • old version (no namespacing)
  • new version (yes namespacing)
  • no version (no namespacing)
  • some future version (who knows)

In the case of the new version (i.e. with namespacing), when I use the Java API to add an element to the tree, if the element itself doesn't already (inherently) contain the same namespacing, it will pick up xmlns=""... which apparently 'clears' the namespacing of the outer elements.


Eric Dalquist [06/Aug/07 11:43 AM]
Containers still work with the non-validating web.xml so this is not critical to get fixed for GA.

Andrew Wills [19/Oct/07 02:18 PM]
Patched to cernunnos-1.0-M3.jar, which does not have this issue.