History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: UP-1685
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Andrew Petro
Reporter: Andrew Petro
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
uPortal

CPortletAdapter fails to handle exceptions on attempt to invalidate portlet session

Created: 09/May/07 02:41 AM   Updated: 27/Sep/07 07:08 AM
Component/s: Portlet Container
Affects Version/s: 2.6.0 M1, 2.5.1 RC1, 2.5.0 GA, 2.5.1 RC2, 2.5.2 RC1, 2.5.1 RC3, 2.5.1 GA, 2.5.3 RC1, 2.5.2 GA, 2.5.3 RC2, 2.5.3 RC3, 2.5.3 GA
Fix Version/s: 2.6.0 RC1

Original Estimate: 15 minutes Remaining Estimate: 0 minutes Time Spent: 15 minutes
Issue Links:
Duplicate
This issue duplicates:
UP-1684 Already invalidated sessions not bein... Major Closed
 


 Description  « Hide
Is this one of those times where a catch Exception would be appropriate? This way regardless of what exception may be raised on attempting to clear a particular portlet's state, recovery and workflow continuation occur. Introduction of additional catches seems to indicate that really the intent here is to apply recovery regardless of what may go wrong.

try {
   PortletStateManager.clearState(windowImpl);
}
catch (IllegalStateException ise) {
   //Ignore an illegal state when the PortletStateManager tries to
   //access the session if it has already been destroyed.
   log.info("Attempted to clear state for window " + windowImpl + " but ISE indicates session had already been destroyed.", ise);
} catch (Exception e) {
   // no matter what went wrong clearing state, there's nothing we can do // about it, and it's desirable to recover and continue the workflow.
   log.error("Error clearing state for window " + windowImpl, e);

}

https://lists.wisc.edu/read/messages?id=1843527#1843527

 All   Comments   Work Log   Change History      Sort Order:
Anthony Colebourne [27/Sep/07 07:08 AM]
After adding the code

catch (IllegalStateException ise) {
//Ignore an illegal state when the PortletStateManager tries to
//access the session if it has already been destroyed.
if (log.isDebugEnabled()) { log.debug("IllegalStateException attempting to clear portlet state for windowImpl " + windowImpl); }
}

We are now seeing this message in our logs.

Tomcat 5.5.17