could you add a default to this PropertiesManager invocation so that in the case where the property is not specified, it defaults to the value that was previously hardcoded? In the case where foks don't need to customize this value, not having to set it at all would be nice.

[
public class RDBMServices {
public static final String BASE_JNDI_CONTEXT = PropertiesManager.getProperty("org.jasig.portal.RDBMServices.baseJndiContext");
]

becomes

[
public class RDBMServices {
public static final String BASE_JNDI_CONTEXT = PropertiesManager.getProperty("org.jasig.portal.RDBMServices.baseJndiContext", "java:comp/env");
]

This also nicely documents an example of a valid value for the property.

Thanks,

Andrew

I don't understand the diff for this change

http://developer.ja-sig.org/source/viewrep/jasig/portal/source/org/jasig/portal/RDBMServices.java?r1=1.53&r2=1.54

specifically, with the introduction of the property,
this:

ds = (DataSource)envCtx.lookup("jdbc/" + name);

became:

ds = (DataSource)envCtx.lookup(name);

Where did the "jdbc/" go and why is it no longer necessary or desirable?

Andrew