History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: UP-1315
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Nick Bolton
Reporter: Ray Sun
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
uPortal

AggregatedUserLayoutStore commits broken transactions -> deadlock

Created: 30/Oct/05 09:24 PM   Updated: 03/Jul/07 04:12 PM
Component/s: Aggregated Layouts
Affects Version/s: 2.4.2, 2.5.0 M1, 2.6.0 M1, 2.5.1 RC1, 2.5.0 RC1, 2.5.0 RC3, 2.5.0 RC2, 2.5.0 GA, 2.5.1 RC2, 2.5.2 RC1, 2.4.4, 2.4.3, 2.5.1 RC3, 2.5.1 GA, 2.4.3.1, 2.5.3 RC1, 2.5.2 GA, 2.5.3 RC2, 2.5.3 RC3, 2.5.3 GA, 2.6.0 RC1
Fix Version/s: 2.5.4, 2.6.0 RC2

Original Estimate: 1 day Remaining Estimate: 1 day Time Spent: Unknown


 Description  « Hide
I am from Guangdong Key Laboratory of Computer Network in South China University of Techonology.
We are using uPortal 2.4.2 in our campus and there're more than 20 thousand users by now.
We have come through several times of rush hours of user logins in the past half a year and recently we found that the login progress using AggregatedUserLayout may cause database dead lock.
       In AggregatedUserLayoutStore.java,the function "public IAggregatedLayout getAggregatedLayout (IPerson person, UserProfile profile) throws PortalException",
        transations should be rolled back if an exception occurs before we commit the transations
        We find the 2.5.1 still have this problem and at least we should do this modification:
        change row 2693 and 2694 into
        "log.error("Error getting aggregated layout for user " + person, e);
         try{RDBMServices.rollback(con);}catch(SQLException sqle){
          log.error( sqle.toString() );
         } "

Presumably this issue affects prior releases of uPortal as well. Research required to determine which ones?

 All   Comments   Work Log   Change History      Sort Order:
Andrew Petro [31/Oct/05 11:38 AM]
Added Fix Versions to put this on the roadmap. Marked as affecting 2.4.4 and fix for 2.4.5 under the assumption that this fix won't make it into 2.4.4, since I see activity today to push unresolveds towards 2.4.5.

Nick Bolton [07/Jun/07 07:16 PM]
Added the rollback code as suggested.