
|
If you were logged in you would be able to see more operations.
|
|
|
|
Original Estimate:
|
Unknown
|
Remaining Estimate:
|
Unknown
|
Time Spent:
|
Unknown
|
|
Issue Links:
|
Generic Relation
|
|
|
|
This issue relates to:
|
|
UP-1070
Remove un necessary classes from org....
|
|
|
|
|
|
|
If you look into the code for Worker (in utils.threading) the
releaseThread method is *only* in the try block. So if there is an
exception the thread is not released. Also though clearState is done in
both try and catch, it is only done if there is a tracker.
We are proposing that both releaseThread and clearState be moved to the
finally block to ensure that they are always called. Does anyone have
any thoughts on this?
As a future refinement it seems that since Task and Tracker are *only*
valid in a particular instance of completing work they should be
encapsulated in a method that actually does the work vs. being in the
general run() class. This would eliminate the need to explicitly call
cleanState() Any thoughts on this also?
|
|
Description
|
If you look into the code for Worker (in utils.threading) the
releaseThread method is *only* in the try block. So if there is an
exception the thread is not released. Also though clearState is done in
both try and catch, it is only done if there is a tracker.
We are proposing that both releaseThread and clearState be moved to the
finally block to ensure that they are always called. Does anyone have
any thoughts on this?
As a future refinement it seems that since Task and Tracker are *only*
valid in a particular instance of completing work they should be
encapsulated in a method that actually does the work vs. being in the
general run() class. This would eliminate the need to explicitly call
cleanState() Any thoughts on this also?
|
Show » |
|
https://list.unm.edu/cgi-bin/wa?A2=ind0503&L=jasig-dev&D=0&m=6774&P=5397