History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: UP-1058
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: Faizan Ahmed
Reporter: Faizan Ahmed
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
uPortal

Worker.java (in utils.threading) the releaseThread method is *only* called in the try block. This call should be in finally block.

Created: 11/May/05 04:16 PM   Updated: 03/Jul/07 04:11 PM  Due: 12/May/05
Component/s: Framework
Affects Version/s: 2.3.5, 2.4, 2.4.1, 2.4.2, 2.5.0 M1, 2.5.0 RC1
Fix Version/s: 2.5.0 RC2

Original Estimate: Unknown Remaining Estimate: Unknown Time Spent: Unknown
Issue Links:
Generic Relation
 
This issue relates to:
UP-1070 Remove un necessary classes from org.... Major Closed


 Description  « Hide
If you look into the code for Worker (in utils.threading) the
releaseThread method is *only* in the try block. So if there is an
exception the thread is not released. Also though clearState is done in
both try and catch, it is only done if there is a tracker.

We are proposing that both releaseThread and clearState be moved to the
finally block to ensure that they are always called. Does anyone have
any thoughts on this?

As a future refinement it seems that since Task and Tracker are *only*
valid in a particular instance of completing work they should be
encapsulated in a method that actually does the work vs. being in the
general run() class. This would eliminate the need to explicitly call
cleanState() Any thoughts on this also?



 All   Comments   Work Log   Change History      Sort Order:
Faizan Ahmed [11/May/05 04:17 PM]
Following is the discussion thread on this issue

https://list.unm.edu/cgi-bin/wa?A2=ind0503&L=jasig-dev&D=0&m=6774&P=5397


Andrew Petro [17/May/05 11:57 AM]
This was resolved by the removal of the Worker class.